search

wodby / docker4drupal

Docker-based Drupal stack
https://wodby.com/docker4drupal
MIT License
1.23k stars 533 forks source link

Update docker-compose.yml with frequently used environment variables … #556

Closed iVegas closed 3 months ago

iVegas commented 8 months ago

…for php container

iVegas commented 8 months ago

closes #507 closes #508

csandanov commented 8 months ago

Hi, why set log level to 0? We probably do need to change the default to 3

iVegas commented 8 months ago

The php image already uses the default log level value if xdebug is enabled. In case I want to change the log level I'll uncomment the line and set a different log level. Unless xdebux connection is not configured by a developer default value is enough to help establish it. Once IDE listens to the web server correctly logging is no longer needed. So frequently used values for xdebug logger level are 3 or 0. That`s why I provided a different to the default value for the xdebug logging level.

csandanov commented 8 months ago

Unless xdebux connection is not configured by a developer default value is enough to help establish it.

The current default log level is 7 which information, I guess it makes sense to change it to 3 (warnings), change it directly in the wodby/php image, not just here through env vars

iVegas commented 8 months ago

Added related PR https://github.com/wodby/php/pull/184