search

wodby / docker4drupal

Docker-based Drupal stack
https://wodby.com/docker4drupal
MIT License
1.24k stars 531 forks source link

php-essentials container #8

Closed fortis closed 7 years ago

fortis commented 8 years ago

maybe it make sense to have container with additional tools, something like that: https://github.com/darh/php-essentials but with alpine

csandanov commented 8 years ago

I think we should determine the most useful and popular tools for Drupal and just add it to the PHP container. Recently, we've added Drupal Console.

lhridley commented 8 years ago

It really makes sense to have the tools available in php-essentials in a separate container. Those tools are primarily for supporting development efforts (they're all testing tools), but offer little to production and in reality should not be included in a production environment.

csandanov commented 8 years ago

please note that this initiative is focused on providing a local environment and this is one of the reasons it's so simple, it's not recommended to use it in production

andypost commented 8 years ago

@lhridley Suppose git, drush & composer are required on "live" for d8

andypost commented 8 years ago

otoh I't makes sense to keep them in separate volume/image container

Like

PS here's similar project https://github.com/RobLoach/Dockie

csandanov commented 8 years ago

Let's figure out first what dev tools are missing that are must have for many drupal devs. Then we can think of adding an additional container (though I'm personally for keeping it as simple as possible) or adding tools to the existing PHP container.

lhridley commented 8 years ago

Pretty much all of the tools in php-essentials, plus the following:

csandanov commented 8 years ago

It seems that https://github.com/darh/php-essentials is no longer supported (last commit in 2014). I suppose we can just add the most popular tools to the main PHP container (cc @PavelPrischepa)

csandanov commented 7 years ago

Phpcs and behat can be installed via composer, git is already in there, selenium container is available on docker hub https://hub.docker.com/r/selenium/. We're open for other suggestions, meanwhile, I'm closing this ticket due to no activity.

jsayegh commented 7 years ago

I tried to setup the behat drupal extension on a docker4drupal stack, it worked only when i didn't enable the drupal api driver in the behat.yml file. I got the following error when i tried to run a test:

PHP Fatal error: Undefined class constant 'MYSQL_ATTR_USE_BUFFERED_QUERY' in /home/gitlab/netto982df6/netto/includes/database/mysql/database.inc on line 56

csandanov commented 7 years ago

@jsayegh do you get this error inside of php container? what is the tag of php image? Could you perhaps open a new issue with more details and steps to reproduce?

jsayegh commented 7 years ago

@csandanov i followed the steps in https://docker4drupal.readthedocs.io/en/latest/ to run the stack. Then i installed the drupal extension (system wide installation: https://behat-drupal-extension.readthedocs.io/en/3.1/globalinstall.html#install-the-drupal-extension). I added the attached behat.yml file in a a directory named tests in /profiles/MY_PROFILE (profiles/MY_PROFILE/tests) behat.yml.zip

jsayegh commented 7 years ago

@csandanov I'm adding subcontexts and .feature files in some of the modules and i'm getting the error when i try run of the tests in a .feature file using the following command : behat -c /path/to/drupal_root/profiles/MY_PROFILE/tests/behat.yml /path/to/drupal_root/profiles/MY_PROFILE/modules/my_module/test.feature and this is the tag of the php image: wodby/drupal-php:5.6-2.0.0