wodby / mariadb

MariaDB docker container image
https://wodby.com/stacks/mariadb
GNU General Public License v2.0
49 stars 31 forks source link

autosize rather than copy default values for system settings #45

Closed grooverdan closed 2 years ago

grooverdan commented 2 years ago

As @ioanma found out in https://github.com/MariaDB/mariadb-docker/issues/413#issuecomment-1046228447, the setting of lower_case_table_names=0 in https://github.com/wodby/mariadb/commit/0f2c8ce53cede151c440877108e458288a1eee86 caused them to fail on start up.

What isn't clear in the documentation, is that lower_case_table_names isn't exactly a default value of 0 on unix, but an auto-determined default value based on lower_case_file_system. As the user has a lower case data directory, this now fails at startup.

MariaDB is going to continue to autoset these settings in a way that gets the best user experience. We really want to see an ideal scenario where only a small amount of tuning is needed.

I understand that you may occasionally want a different default for you users, however that should be a special case rather than just providing a environment variable with the current default value at the time of commit.

The current dangerous defaults I see on a very quick examination are:

So as a feature request for our communities, can the default configuration files of wodby/mariadb work their way back to being a default, or where there is a divergence in configuration from default, this is documented in the configuration file for the awareness of the user, and you as a maintainer. As nextcloud discovered, the use of non-defaults can result in hardship for the user communities.

csandanov commented 2 years ago

Hi, thank you for your recommendations. I've reworked defaults and introduced some new env vars to adjust it if needed.

grooverdan commented 2 years ago

thanks