search

wodby / mariadb

MariaDB docker container image
https://wodby.com/stacks/mariadb
GNU General Public License v2.0
49 stars 31 forks source link

Fix for find and patch #6

Closed tetsumaki closed 6 years ago

tetsumaki commented 6 years ago
  1. If errors during the patch during for loop. This does not stop the build and xargs must be used. It is not possible to use the "exec" argument of the find command for the same reasons
  2. The maxdept argument must be used before in the find command. This affects performance
csandanov commented 6 years ago

See https://circleci.com/gh/wodby/mariadb/159

patching file scripts/CMakeLists.txt
Hunk #1 FAILED at 175.
1 out of 1 hunk FAILED -- saving rejects to file scripts/CMakeLists.txt.rej

The patching error has stopped the build, we have set -e in the beginning of Dockerfile

tetsumaki commented 6 years ago

True.

I have tested with :

&& for i in /tmp/patches/"${MARIADB_VER:0:4}"/*.patch; do patch -p1 -i "${i}"; done \

And you :

for i in /tmp/patches/"${MARIADB_VER:0:4}"/*.patch; do patch -p1 -i "${i}"; done; \

With my line, the build continue if I do not use xargs.

Sorry ;)

csandanov commented 6 years ago

Also, it seems we already have maxdepth params in place