search

wodby / php

Generic PHP docker container images
MIT License
155 stars 103 forks source link

Enabling PCOV produces warnings; Delimiter must not be alphanumeric or backslash #152

Closed eelkeblok closed 3 years ago

eelkeblok commented 3 years ago

We are using wodby/drupal-php in a CI setup for running automated tests. I just enabled PCOV by setting the PHP_PCOV_ENABLED environment variable to 1 in my docker-compose.yml. This seems to work fine, except that I see warnings appear in the console output stating "Warning: Unknown: Delimiter must not be alphanumeric or backslash in Unknown on line 0". Googling suggests this error is coming from preg_match(), but it is not in my code and since it only appears when enabling Pcov, there seems to be a connection. Is this a known issue? Any hints what to change? I could not find anything for the combination of this error and Pcov (let alone this Docker image) so it would seem to be something pretty specific.

eelkeblok commented 3 years ago

I did some more digging and based on https://github.com/krakjoe/pcov/issues/35 I figured the exclude setting might be the source of the problem. I included this in my docker-compose:

      - PHP_PCOV_EXCLUDE=""

It fixed the issue. I'll create a PR that should fix the problem. Edit: #153