search

wodby / php

Generic PHP docker container images
MIT License
155 stars 103 forks source link

Empty the default setting for PHP_PCOV_EXCLUDE #153

Closed eelkeblok closed 3 years ago

eelkeblok commented 3 years ago

See #152.

csandanov commented 3 years ago

are you sure that fixes it? I think the issue here is that pcov.exclude expects a string in the value and it should be additionally wrapped in quotes like this:

pcov.exclude = "{{ getenv "PHP_PCOV_EXCLUDE" "unused" }}"

The default value should unused according to the extension docs.

csandanov commented 3 years ago

Neither fixes it, reported https://github.com/krakjoe/pcov/issues/72

csandanov commented 3 years ago

Actually you were right 🤦🏻‍♂️ I just confused PHP versions and configs while testing