search

wodby / php

Generic PHP docker container images
MIT License
155 stars 103 forks source link

Drop mcrypt for PHP 7.1 #3

Closed rodrigoaguilera closed 6 years ago

rodrigoaguilera commented 7 years ago

Since mcrypt in PHP 7.1 Raises exceptions https://wiki.php.net/rfc/mcrypt-viking-funeral

I think the wisest thing is to remove.

What software dependending on this image requires mcrypt?

csandanov commented 7 years ago

In PHP 7.1, all mcrypt_* functions will raise an E_DEPRECATED notice.

I think it's OK, you won't see any notices unless you use these functions. What exceptions do you get?

rodrigoaguilera commented 7 years ago

No extra exceptions but from calling the functions but I feel is more neat not to keep nor maintain deprecated code. But I just wanted the opinion so is OK.

csandanov commented 6 years ago

mcrypt preserved for 7.2 (installed from pecl) because a lot of frameworks still use it