wodby / php

Generic PHP docker container images
MIT License
155 stars 103 forks source link

Why is prestissimo not included in the dockerfile? #82

Closed jbertoen closed 5 years ago

jbertoen commented 5 years ago

Documentation mentions the prestissimo composer library. But it is not included anymore since https://github.com/wodby/php/commit/ef87ee87271c041522b71df48b7462dc06bbd853

Why is that?

csandanov commented 5 years ago

this package caused composer install failures https://github.com/wodby/docker4drupal/issues/365

here's explained why: https://github.com/drupal-composer/drupal-scaffold/issues/101#issuecomment-488758925

SyneticDevOps commented 5 years ago

Why not make it optional with an env variable setting and require it through an init.sh script in the entrypoint setup? Tried that and seems to work. Do not get any issues for now...