wodby / php

Generic PHP docker container images
MIT License
155 stars 103 forks source link

Consider replacing tideways xhprof with updated PECL version #96

Closed csandanov closed 3 years ago

csandanov commented 4 years ago

As was suggested in https://github.com/wodby/xhprof/issues/1 a new version https://pecl.php.net/package/xhprof has been released (fork of the original) with PHP 7.x support. We're currently using https://github.com/tideways/php-xhprof-extension/

andypost commented 4 years ago

Tideways is a bit different but output data should be the same. I can't find fresh comparison but as both extensions using timers so no serious diff expected. Xhprof from pecl ships viewer but that's separate image

csandanov commented 3 years ago

Tideways xhprof has been replaced with pecl xhprof

jcisio commented 3 years ago

FWIW, yesterday Tideways xhprof generated a few 1.5 - 2.5 MB files that could not be read by xhprof viewer (the symbol array is null). Replaced that extension with the PECL package and it worked. PHP 7.4 and it was working, maybe this time the output was large (the script took more than 60s to run). Tested with a smaller script and the viewer could read well the output data.