Closed pprishchepa closed 5 years ago
I noticed possible issue in varnish config:
https://github.com/wodby/varnish/blob/master/templates/defaults/vcl_recv.vcl.tmpl#L34
"^[; ]+|[; ]+$"
a regexp consists of 2 identical parts [; ]
[; ]
It seems cookies does not affect hash here, so this block looks useless. I tested with FooCookieName=BarValue cookie and it does not affect on cache hash (VARNISH_KEEP_ALL_COOKIES was not enabled).
FooCookieName=BarValue
VARNISH_KEEP_ALL_COOKIES
This means delete ; at the start and the end.
;
We also use in Drupal preset and it's commented as:
# 5. Remove all spaces and semi-colons from the beginning and end of the # cookie string.
I noticed possible issue in varnish config:
https://github.com/wodby/varnish/blob/master/templates/defaults/vcl_recv.vcl.tmpl#L34
a regexp consists of 2 identical parts
[; ]
It seems cookies does not affect hash here, so this block looks useless. I tested with
FooCookieName=BarValue
cookie and it does not affect on cache hash (VARNISH_KEEP_ALL_COOKIES
was not enabled).