search

wodim / wow-discord-rich-presence

Discord rich presence for World of Warcraft
Other
3 stars 1 forks source link

Support for maximized window mode borderless? #2

Open Violet-Vibes opened 4 years ago

Violet-Vibes commented 4 years ago

is it possible to make this script work while having wow in windowed maximized mode?

wodim commented 4 years ago

Have you tried changing the height variable? 0 would be a good start

https://github.com/wodim/wow-discord-rich-presence/blob/master/script/wow.py#L34-L36

Violet-Vibes commented 4 years ago

seems it cuts off the first square when i try height 0, any ideas?

Violet-Vibes commented 4 years ago

image

image

Notice on how the debug, the first square is half

hawaiisa commented 4 years ago

I'm not able to try it out right now, but I've been looking for the same thing and got the same result with height 0. I might've found a thread that can be of assistance: https://stackoverflow.com/questions/34139450/getwindowrect-returns-a-size-including-invisible-borders

wodim commented 4 years ago

Honestly I have no idea, I haven't touched the code in a long time (and this part sucks since it should work automatically but I never got around to fixing it)

https://github.com/wodim/wow-discord-rich-presence/blob/master/script/wow.py#L38-L39

Try to remove the +8 and -8 part

Violet-Vibes commented 4 years ago

That seems to have done the trick, thanks!

On Tue, 8 Sep 2020 at 23:24, wodim notifications@github.com wrote:

Honestly I have no idea, I haven't touched the code in a long time (and this part sucks since it should work automatically but I never got around to fixing it)

https://github.com/wodim/wow-discord-rich-presence/blob/master/script/wow.py#L38-L39

Try to remove the +8 and -8 part

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wodim/wow-discord-rich-presence/issues/2#issuecomment-689143964, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEUWN2DSOTDZ2SZ5F5LM7BTSE2OH5ANCNFSM4RAHNFKQ .

Violet-Vibes commented 4 years ago

On another note, would it be possible to extend the information shown, such as Class, Level, Race, server?

wodim commented 4 years ago

I mean, it would, but you would have to make the changes yourself...

Violet-Vibes commented 4 years ago

Understandable, was hoping you could nudge me in the right direction :P

On Wed, 9 Sep 2020 at 09:43, wodim notifications@github.com wrote:

I mean, it would, but you would have to make the changes yourself...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wodim/wow-discord-rich-presence/issues/2#issuecomment-689373231, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEUWN2BFDV5CZUQ3GXCOOLDSE4WY5ANCNFSM4RAHNFKQ .

wodim commented 4 years ago

Change https://github.com/wodim/wow-discord-rich-presence/blob/master/IPC%20(WotLK)/IPC.lua#L94-L128 so it returns something different, like "$WorldOfWarcraftIPC$Level 80 Hunter|Warmane Icecrown$WorldOfWarcraftIPC$", obviously using the correct API calls from https://wow.gamepedia.com/World_of_Warcraft_API. The Python script won't need to be modified.

Violet-Vibes commented 4 years ago

Thank you, I'll play around with it

On Wed, 9 Sep 2020 at 11:39, wodim notifications@github.com wrote:

Change https://github.com/wodim/wow-discord-rich-presence/blob/master/IPC%20(WotLK)/IPC.lua#L94-L128 so it returns something different, like "$WorldOfWarcraftIPC$Level 80 Hunter|Warmane Icecrown$WorldOfWarcraftIPC$", obviously using the correct API calls from https://wow.gamepedia.com/World_of_Warcraft_API. The Python script won't need to be modified.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wodim/wow-discord-rich-presence/issues/2#issuecomment-689450148, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEUWN2BS26OKGW4RA36O34LSE5EL7ANCNFSM4RAHNFKQ .