search

woefe / ytcc

Command line tool to keep track of your favorite playlists on YouTube and many other places.
GNU General Public License v3.0
178 stars 20 forks source link

Remove subshell #74

Closed Glandos closed 3 years ago

Glandos commented 3 years ago

fzf supports field index expression, that trims the value by default, so a subshell is not needed.

It also has the advantage not to rely on shell syntax, because since $SHELL variable is not set, fzf use the user shell to execute the preview, and it can have wrong result. I was impacted as a fish user.

woefe commented 3 years ago

I've also replaced pipes with fzf's index expressions and merged / squashed those changes in fff04a8