wofferl / proxmox-backup-arm64

Script for building Proxmox Backup Server 3.x (Bookworm) for Armbian64
151 stars 12 forks source link

update proxmox-backup to 2.4.1-1 #28

Closed MAFLO321 closed 1 year ago

MAFLO321 commented 1 year ago
MAFLO321 commented 1 year ago

~Proxmox backup server 2.4.0-2 is not yet released.~ I will remove "Draft" state of PR when it is released. -> done

wofferl commented 1 year ago

I have merged your 2.4.0-2 changes. Please push commits only after you have compiled and tested it successfully. Thanks for your work.

MAFLO321 commented 1 year ago

First, thanks for merging :smile: .

I always compile and test the stuff I push. Just Proxmox never released the packages for 2.4.0-2 a directly went to 2.4.1-1, that's why I marked the PR as draft?

For the future, should I change my workflow:

@wofferl What do you think about the two options for the future?

wofferl commented 1 year ago

This is not really a complex or professional project where you need guidelines or have to rush when new versions came out. In most cases it is only change the revisions.

The problem in this case was, that you removed the draft and rushed your changes for the 2.4.1 change, so you had to force-push multiple times to correct them.

This doesn't make it easier to track, so better to test and compile through first before pushing the changes.

MAFLO321 commented 1 year ago

Okay, I will do my best, to not rush over and over again the next time. Thanks anyway.