Closed carmanber closed 11 months ago
Hi and thank you! I’m currently on vacation and will review when I return!
On Thu 24. Aug 2023 at 21:25, carmanber @.***> wrote:
Hi,
I modified the code function as discussed on the HA forum: https://community.home-assistant.io/t/blind-automation-written-in-appdaemon-made-for-homeassistant/228315 to make it work with the latest AppDaemon version I also changed the readme.md to reflect the current practice in AppDaemon and HomeAssistant.
Test successfully at home, no error nor warning.
Feel free to come back to me for any questions
You can view, comment on, or merge this pull request online at:
https://github.com/wogri/hass-blinds/pull/7 Commit Summary
- 42c178f https://github.com/wogri/hass-blinds/pull/7/commits/42c178f8e06d5597a2cd83ddc476b483a30e9aea I modified the code so to support the latest version of AppDaemon and HomeAssistant
- f8786e0 https://github.com/wogri/hass-blinds/pull/7/commits/f8786e00d322ce7ab1425df015b50fc808ef28cc Delete TODO
File Changes
(6 files https://github.com/wogri/hass-blinds/pull/7/files)
- M README.md https://github.com/wogri/hass-blinds/pull/7/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5 (65)
- D apps.yaml https://github.com/wogri/hass-blinds/pull/7/files#diff-720da4eb5d8fd5e52a18ef99b232d8f5ff174d6c7105def70dabf02eab9461d7 (417)
- M blinds.py https://github.com/wogri/hass-blinds/pull/7/files#diff-f7a003c3e9faa2efb42961d7313fd4a56f31b5f196810bf3a707a62dafc49969 (9)
- M lib/blinds_lib.py https://github.com/wogri/hass-blinds/pull/7/files#diff-c620f8d46f4825c4aea813bf3b43ac604d8de2a81bb4a2e58c265f64126e4e78 (1)
- M max_temp.py https://github.com/wogri/hass-blinds/pull/7/files#diff-e10d555e6824588bc54bf252be26370f73aebe6146cf24c22f4c1c7ee0c1eec8 (7)
- M sun.py https://github.com/wogri/hass-blinds/pull/7/files#diff-495e5ada352469dde625a7c6b248be4e15c86e90c2e6566a1a341271e406f5f4 (6)
Patch Links:
— Reply to this email directly, view it on GitHub https://github.com/wogri/hass-blinds/pull/7, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABF243WLZUJ6SSIPEIS7DALXW6TBXANCNFSM6AAAAAA35PR6DE . You are receiving this because you are subscribed to this thread.Message ID: @.***>
Hi,
I modified the code function as discussed on the HA forum: https://community.home-assistant.io/t/blind-automation-written-in-appdaemon-made-for-homeassistant/228315 to make it work with the latest AppDaemon version I also changed the readme.md to reflect the current practice in AppDaemon and HomeAssistant.
Test successfully at home, no error nor warning.
Feel free to come back to me for any questions