search

wogscpar / SZZUnleashed

An implementation of the SZZ algorithm, i.e., an approach to identify bug-introducing commits.
MIT License
109 stars 75 forks source link

Wrong pair order in SimpleBugIntroducerFinder #38

Open markus7800 opened 2 years ago

markus7800 commented 2 years ago

It seems to me that in the following code snippet

https://github.com/wogscpar/SZZUnleashed/blob/79f369fe2ccd2ae8c12d4e38edf71e7d988a8c68/szz/src/main/java/heuristics/SimpleBugIntroducerFinder.java#L180-L207

pair[0] is a bug-introducing commit, and pair[1] is a bug-fixing commit as defined in the issue list.

However, in line 193 (as well as in line 224), I think the order of the pair should be (bug-fixing commit, bug-introducing commit), so (pair[1], pair[0]).

Is this correct or am I missing something?