search

wohaph / keyczar

Automatically exported from code.google.com/p/keyczar
0 stars 0 forks source link

Request for pull: Fix issues 100, 101, 102, 103 #104

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Greetings!

I'd like to request a review and merge of the following revisions from the 
clone "mtomczak-keyczartool-edits." 

http://code.google.com/r/mtomczak-keyczartool-edits/source/detail?r=7ce973adf0ba
bfae1fe5cf78986ba3058baca862
http://code.google.com/r/mtomczak-keyczartool-edits/source/detail?r=77ff24e17717
73b82f6197065a1287c15cc90434
http://code.google.com/r/mtomczak-keyczartool-edits/source/detail?r=ebbdffdde93a
4e22eff57482d00716752275ea5c

These three edits address issues 100, 101, 102, and 103 by doing the following:

* Updating the documentation for the usekey command in keytool to match its 
(new ) behavior.
* Changing command-line argument processing for keytool to no longer conflate 
--flags with non-flag arguments (so "usekey msg --location=foo" is now 
interpreted the same as "usekey --location=foo msg")
* Changing --destination to an optional flag for usekey. If destination is not 
specified, output goes to stdout instead of a file.

Additionally, for symmetry, if 'message' is not specified for the usekey 
command, the message to encrypt is read from stdin.

Feel free to contact me if there are any questions. This is my first pull 
request, so if I've made an error on procedure, please let me know and I will 
correct it.

Thank you for your time!
-Mark

Original issue reported on code.google.com by mtomc...@google.com on 26 Aug 2012 at 5:12

GoogleCodeExporter commented 9 years ago

Original comment by jtu...@gmail.com on 2 Mar 2013 at 9:25

GoogleCodeExporter commented 9 years ago

Original comment by jtu...@gmail.com on 4 Jul 2013 at 4:37

GoogleCodeExporter commented 9 years ago 
Merged in fixes 
https://code.google.com/p/keyczar/source/detail?r=1a3f6b1480339d81aa259c20e75e8d
137a2a9621

Original comment by dlundb...@google.com on 20 Aug 2013 at 7:41

GoogleCodeExporter commented 9 years ago

Original comment by dlundb...@google.com on 9 Sep 2013 at 5:46