search

wohaph / keyczar

Automatically exported from code.google.com/p/keyczar
0 stars 0 forks source link

Code review request of branch fix_hash #67

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes on this branch:  This branch fixes an incorrect 
computation of AES key hashes when the keys have leading zero bytes.  This bug 
made approximately one in 256 AES keys incompatible with the Java, Python and 
reference implementations.

Notice that there are two commits on the branch.  The first introduces a test 
case which demonstrates the bug -- by failing.  The second adds the code to fix 
the bug, maintaining backward compatibility.

After the review, I'll merge this branch into master.

The commits are:

http://code.google.com/p/keyczar/source/detail?r=8e4f0a7b59124910f21f8a680637b14
e677c9c02&name=fix_hash

http://code.google.com/p/keyczar/source/detail?r=1cc7dd5f151b071cd16864b177625bc
965175b6e&name=fix_hash

Original issue reported on code.google.com by swillden@google.com on 5 Sep 2011 at 6:08

GoogleCodeExporter commented 9 years ago 
LGTM

Original comment by dasho...@gmail.com on 6 Sep 2011 at 6:57

GoogleCodeExporter commented 9 years ago 
Merged to master.

Original comment by swillden@google.com on 6 Sep 2011 at 7:53