Fails to render SVG in HTML in night mode

woheller69 / browser

A privacy oriented web browser with Greasemonkey style script support and Cookie Banner Blocker

GNU General Public License v3.0

160 stars 18 forks source link

Fails to render SVG in HTML in night mode #39

Closed StevanWhite closed 3 months ago

StevanWhite commented 3 months ago

The browser fails to render the embedded SVG in the attached example, when in Night mode.

To see this, first either

set the system to night mode (Android 11+) and set Free Browser's UI to follow the system, or
set the Free Browser UI to night mode directly

unzip the attached file, and open it with an Android file manager, then choose Free Browser.

The HTML is rendered, but the SVG is not.

The default colors in the SVG should be set similarly to the colors for rendering HTML. (I think what is going on here is... the color ("black") is changed to white in Night mode, but the background (fill) color ("white") is left as white, resulting in invisible text and lines.)

five_cell.html.gz

woheller69 commented 3 months ago

Is there an URL that does not work? If so, webview probably does not support it

StevanWhite commented 3 months ago

? I don't know what URL you refer to.

The issues are: how to handle Night mode, and how best to set colors in embedded SVG, when in night mode. Here, something has gone so wrong as to make a simple line drawing invisible.

It should also be easy for a programmer to fix.

woheller69 commented 3 months ago

Night mode is handled by webview. I have no influence on this. It is up to the website to offer a night mode

StevanWhite commented 3 months ago

Hi,

We may be misunderstanding one another.

This has nothing to do with websites.

This is about how your app responds to Android 11+ night mode, when rendering an HTML document.

If your app uses a library that misbehaves, you really ought to pass the information up to the maintainers of that library.

woheller69 commented 3 months ago

Feel free to pass it to Google...

woheller69 commented 3 months ago

See here, how algorithmic darkening works https://developer.android.com/develop/ui/views/layout/webapps/dark-theme

StevanWhite commented 3 months ago

That is too bad.

On Fri, Mar 8, 2024 at 9:21 PM woheller69 @.***> wrote:

Feel free to pass it to Google...

— Reply to this email directly, view it on GitHub https://github.com/woheller69/browser/issues/39#issuecomment-1986364641, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMA3OO4GOCKWB2JYVXN6I3YXIMU7AVCNFSM6AAAAABEMQPDV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWGM3DINRUGE . You are receiving this because you authored the thread.Message ID: @.***>

woheller69 commented 3 months ago

Either: WebView renders the content with the dark theme that the content author has defined.

Or: If allowed by the content author, WebView renders the content with a dark theme that is generated using an algorithm.

So its up to the designer of the website to either define a night scheme or to allow/forbid algorithmic darkening