Add file upload feature for Advanced Data Analysis; bump version to 1.10

woheller69 / gptAssist

gptAssist is a simple WebView wrapper for ChatGPT

GNU General Public License v3.0

226 stars 6 forks source link

Add file upload feature for Advanced Data Analysis; bump version to 1.10 #21

Closed 0xEva closed 8 months ago

0xEva commented 9 months ago

Implemented file upload capabilities within the app, allowing users to select and upload files to Advanced Data Analysis.
Incremented the app version code from 1.9 to 1.10 to reflect the new feature addition.

woheller69 commented 9 months ago

unfortunately I cannot test that as I do not have the paid version of ChatGPT...

Don't we need to request permission for READ_EXTERNAL_STORAGE?

  if (checkSelfPermission(Manifest.permission.READ_EXTERNAL_STORAGE) != PackageManager.PERMISSION_GRANTED) 
    requestPermissions(new String[]{Manifest.permission.READ_EXTERNAL_STORAGE}, 100)

0xEva commented 9 months ago

You are right. Thanks for pointing that out! If I understand correctly, for API >= 23, the permission is now requested at runtime. For earlier versions, it's granted during installation.

woheller69 commented 9 months ago

Thanks. Looks good. Will merge when I am back from vacation.