Closed johnpbloch closed 8 months ago
I just worked a bit on it, but it just causes problems. The chart will not work properly with it, because it only supports integer axis values. And I will for sure not change the chart library...
So the range for precipitation will be 4"
You can try it. But I don't think I will publish it. -Uninstall -Remove .zip and install
Maybe if the number of steps is reduced to 2 for the chart in inches.
V2.5
This is meant to address #21
First of all, thanks for your work on this app! I find it very useful each day and I appreciate all the work that you've put into it.
Now on to this PR. I would find it useful to have the option to switch precipitation to display in inches rather than millimeters. It's not that I can't get a good approximate converted value mentally, it's just that I'd rather not have to. So I'd like to get the effort started. Now, I'm really not an Android dev, not even a java dev, so I'm sure there's more to be done with this code before it can be merged. I've reached the limit of where I feel comfortable inferring code patterns, etc. from the existing codebase, so I figured I'd submit this as a draft and ask for help getting it over the finish line. I'm happy to do as much of the remaining work as I can, but I need to be pointed in the right direction.
Some things I can already tell you I didn't touch and would appreciate some assistance:
Thanks for your patience and I'd appreciate any assistance you can offer to get this merge-ready.