search

wojnilowicz / workrave-applet

KDE Plasma 5 applet for displaying Workrave timers.
GNU General Public License v2.0
4 stars 7 forks source link

po: Add French translation #3

Closed petitlapin closed 4 years ago

petitlapin commented 4 years ago

Hi, first of all, thank you for all your work in KDE for Polish translation.

It would be nice to add a context for the 2 strings that are tooltips, I had a hard time understanding them (and I'm not 100% sure). Just in case, to add translator comments in qml, it is "//: comment".

Here is the French translation.

Johnny

wojnilowicz commented 4 years ago

Hi Johnny,

first of all, thank you for all your work in KDE for Polish translation.

Oh. Thank you. You must mean a contribution to GCompris translation specifically. I thought that you were only programming it :)

It would be nice to add a context for the 2 strings that are tooltips, I had a hard time understanding them (and I'm not 100% sure).

You mean these two tooltips?: 1) "Disable if performance is of concern, and you want to update it manually in context menu." 2) "Set higher if performance is of concern, and you don't need frequent timer readings."

I see that the first one could be difficult to understand without a context or real world test. I hope the explanation below will make it clearer:

ad 1. It concerns the option "Detect Workrave configuration changes". If e.g. user changes a break time/duration in Workrave (the main application, not the Applet) then the Applet must recalculate ticks each progress bar contains. The Applet can query Workrave periodically for configuration changes, or, if you don't change Workrave configuration that often, then you could right click on the Applet and refresh the configuration by yourself.

ad 2. It concerns the option "Update interval in seconds" If the user will set it to e.g. 5 s then on the progress bar he will be seeing consecutively e.g. 5:30, 5:35 instead of 5:30, 5:31, 5:32, 5:33, 5:34, 5:35.

Just in case, to add translator comments in qml, it is "//: comment".

I will do it by using function i18nc instead of i18n so the comment would should show up in Lokalize. Thank you for the tip.

Here is the French translation.

Thank you for your fast response and the translation. Do you want to re-translate those tooltips or is it OK, as it is now?

Regards Łukasz

petitlapin commented 4 years ago

Hi Johnny,

first of all, thank you for all your work in KDE for Polish translation.

Oh. Thank you. You must mean a contribution to GCompris translation specifically. I thought that you were only programming it :)

Not specifically GCompris as if I understood correctly you also translate other KDE software for Polish. But yes, as a GCompris developer, it is great to have it translated in Polish too :). I'm also trying to help the French translation team at my level.

It would be nice to add a context for the 2 strings that are tooltips, I had a hard time understanding them (and I'm not 100% sure).

You mean these two tooltips?:

1. "Disable if performance is of concern, and you want to update it manually in context menu."

2. "Set higher if performance is of concern, and you don't need frequent timer readings."

Yes, those two.

I see that the first one could be difficult to understand without a context or real world test. I hope the explanation below will make it clearer:

ad 1. It concerns the option "Detect Workrave configuration changes". If e.g. user changes a break time/duration in Workrave (the main application, not the Applet) then the Applet must recalculate ticks each progress bar contains. The Applet can query Workrave periodically for configuration changes, or, if you don't change Workrave configuration that often, then you could right click on the Applet and refresh the configuration by yourself.

Yes, I read the code and found there it was a tooltip related to the previous text. That's why I think it could be helpful for translators that won't go to the source code to have a comment.

ad 2. It concerns the option "Update interval in seconds" If the user will set it to e.g. 5 s then on the progress bar he will be seeing consecutively e.g. 5:30, 5:35 instead of 5:30, 5:31, 5:32, 5:33, 5:34, 5:35.

Just in case, to add translator comments in qml, it is "//: comment".

I will do it by using function i18nc instead of i18n so the comment would should show up in Lokalize. Thank you for the tip.

Here is the French translation.

Thank you for your fast response and the translation. Do you want to re-translate those tooltips or is it OK, as it is now?

You're welcome!

Yes, I'm going to improve them, I totally misunderstood the second one, I'll update this PR :).

Regards Łukasz

wojnilowicz commented 4 years ago

Not specifically GCompris as if I understood correctly you also translate other KDE software for Polish. But yes, as a GCompris developer, it is great to have it translated in Polish too :). I'm also trying to help the French translation team at my level.

That's true, I translate other KDE software into Polish as well. Thank you for noticing it. And thank you for developing GCompris. I think I might need it some day :)

I'm not sure i18n and i18nc are available for qml (I always had to use qsTr() and using "//:" shows the comment in Lokalize).

I did a local test, and messages got extracted to a .pot file with the comment, so I think it's available. I will keep in mind the qsTr() trick though, just in case :)

Yes, I'm going to improve them, I totally misunderstood the second one, I'll update this PR :).

It's merged.