search

wojodesign / simplecart-js

A simple javascript shopping cart that easily integrates with your current website.
simplecartjs.org
1.79k stars 492 forks source link

taxShipping not applied #239

Closed swfredrik closed 12 years ago

swfredrik commented 12 years ago 
Setting the shipping and tax as follow:

// flat rate shipping option shippingFlatRate: 24,

    // added shipping based on this value multiplied by the cart quantity
    shippingQuantityRate: 0,

    // added shipping based on this value multiplied by the cart subtotal
    shippingTotalRate: 0,

    // tax rate applied to cart subtotal
    taxRate: 0.25,

    // true if tax should be applied to shipping
    taxShipping: true,

simpleCart_shipping will give me 24 simpleCart_grandTotal will give me 24, I believe the tax should apply to the grandTotal so the grandTotal would be 30.

setting the taxShipping true or false does no effect.

brettwejrowski commented 12 years ago

@swfredrik thanks for bringing this up, I'll make sure it is being applied correctly in the next patch (I should actually get to this and your other issue today)

brettwejrowski commented 12 years ago

hey @swfredrik I just fixed this and merged to master, you should be all set now.

swfredrik commented 12 years ago

Hi, Great thanks! Really nice! Thanks a bunch!!