wojtekmach / req

Req is a batteries-included HTTP client for Elixir.
https://hexdocs.pm/req
Apache License 2.0
1.09k stars 117 forks source link

use `:finch` value to override finch instance #391

Closed slapers closed 4 months ago

slapers commented 4 months ago

Hi, I was unable to override the finch instance and traced it back to commit https://github.com/wojtekmach/req/commit/7ee7fd8effe22fd59d87723c86ba652d4a0c6a0e which removed the functionality.

This PR should revert that + adds a test to check that the :finch option can be used.

wojtekmach commented 4 months ago

Oof, good catch, thank you for the PR. We should have a new release by end of the week.