search

wojtekmach / req

Req is a batteries-included HTTP client for Elixir.
https://hexdocs.pm/req
Apache License 2.0
1.09k stars 117 forks source link

fix: encode path in url for aws_sigv4_url/1 #433

Closed fahchen closed 5 days ago

fahchen commented 5 days ago

I encountered a SignatureDoesNotMatch when the object key contains characters that need to be escaped, such as spaces or CJK characters.

The path has been encoded at 168L, so we just update the url before returning. https://github.com/wojtekmach/req/blob/a3c48b845119069909e9197cd53264782513b4b4/lib/req/utils.ex#L168

wojtekmach commented 5 days ago

Thank you!