search

wojtekmaj / get-user-locale

A function that returns user's locale as an IETF language tag, based on all available sources.
MIT License
58 stars 9 forks source link

Configurable fallback locale #17

Closed sebinemeth closed 2 years ago

sebinemeth commented 3 years ago

Hi, I implemented the configurable fallback locale proposed in PR https://github.com/wojtekmaj/get-user-locale/pull/6. In addition, fallback behavior can be disabled.

sebinemeth commented 3 years ago

Finally managed to fix all the test cases as well. Please review.

wojtekmaj commented 3 years ago

I will gladly review. Extremely busy right now but I have it in mind.

sebinemeth commented 3 years ago

Hi, Any news on this one? Thanks!

danielztolnai commented 2 years ago

Hi @wojtekmaj, sorry to bother you, but is there any chance to get this merged?

gazben commented 2 years ago

@wojtekmaj I've rebased the changes to the current main and resolved the conflicts. Can you take a look?

wojtekmaj commented 2 years ago

I couldn't edit this branch so I worked on this a bit more and merged it as a05dc6b, while adding you both as co-authors. Thank you for your contribution!

gazben commented 2 years ago

@wojtekmaj Can you create a new release to npm? Also I guess this can be closed: https://github.com/wojtekmaj/get-user-locale/pull/6