search

wojtekmaj / react-calendar

Ultimate calendar for your React app.
https://projects.wojtekmaj.pl/react-calendar
MIT License
3.46k stars 497 forks source link

Fix typo in component name #888

Closed ssi02014 closed 11 months ago

ssi02014 commented 11 months ago

Hello 👋, @wojtekmaj Thanks for sharing this great library. I fixed a typo in the component name.

wojtekmaj commented 11 months ago

Hi!

Most of your changes, removing React.FC are causing duplicated types to be produced, resulting in errors in some IDEs. This has been fixed in 70bd390e096e0680fa8c50c70e6bd696cd30bb7c and I have no plans of rolling it back unless a better solution is proposed.

The typo is legit though. :D

ssi02014 commented 11 months ago

@wojtekmaj Thanks for the review. 🙏 I'll revert the part about React.FC.

ssi02014 commented 11 months ago

@wojtekmaj Thank you for informing me about https://github.com/wojtekmaj/react-calendar/commit/70bd390e096e0680fa8c50c70e6bd696cd30bb7c. I have modified the code again.

wojtekmaj commented 11 months ago

Thanks! 👍

ssi02014 commented 11 months ago

@wojtekmaj Thank you for the detailed review. I am pleased to make a small contribution to the react-calendar repository 🎉