wojtryb / Shortcut-Composer

Krita plugin for creating complex keyboard shortcuts
GNU General Public License v3.0
261 stars 9 forks source link

Pie Menus and their Settings are not displayed correctly on XFCE desktop enviroment #41

Closed Axis4s closed 1 year ago

Axis4s commented 1 year ago

image image So not sure what happen but sometimes, the Config menu for pies are invisible, i think this happens when you quickly tap the composer pie shortcuts image and sometimes it takes the focus off the krita's main window

wojtryb commented 1 year ago

Hi, you'd have to be more descriptive of what's the issue, as I don't fully understand how to interpret your screenshots.

First screenshot shows a pie which is not in "edit mode", as the settings button is visible. Pies should always start in non-editable mode.

I don't understand what are you trying to show on the second screenshot.

On third screenshot, are you trying to show that the krita window is out of focus? Technically pie and its settings are separate windows, so clicking on them would unfocus the main window. Closing them should bring the focus I guess.

Axis4s commented 1 year ago

Look at the mouse cursor in the first picture. It should be a basic outline spherical cursor. That's the cursor used when your pen is directly on Krita's Canvas. Instead the cursor is on default. It shouldn't be like that. And that area where I'm hovering at is exactly where the Config window for the pie is located at. The 2nd Picture is to make it more clearer, I even have one of the tools selected

On Thu, Apr 27, 2023, 10:14 AM Wojciech Trybus @.***> wrote:

Hi, you'd have to be more descriptive of what's the issue, as I don't fully understand how to interpret your screenshots.

First screenshot shows a pie which is not in "edit mode", as the settings button is visible. Pies should always start in non-editable mode.

I don't understand what are you trying to show on the second screenshot.

On third screenshot, are you trying to show that the krita window is out of focus? Technically pie and its settings are separate windows, so clicking on them would unfocus the main window. Closing them should bring the focus I guess.

— Reply to this email directly, view it on GitHub https://github.com/wojtryb/Shortcut-Composer/issues/41#issuecomment-1525775311, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXHB2NSIW6X6XMBYW3EFSYLXDJ5MRANCNFSM6AAAAAAXNEPHBQ . You are receiving this because you authored the thread.Message ID: @.***>

wojtryb commented 1 year ago

You shouldn't really click on the canvas or move your cursor out of the pie when selecting an icon. It's fine that the cursor is not interacting with krita main window.

If you mean that when entering the edit mode the window is there, but is not displayed - it's probably some display error specific to your distribution, and I can't do much about it.

Are you using appimage version of krita?

Axis4s commented 1 year ago

I was using the AUR version of krita

wojtryb commented 1 year ago

Appimage is the only officially supported version of krita. It contains some custom Qt patches.

I can't guarantee it's gonna work on that version, but it's worth trying

wojtryb commented 1 year ago

Is there any progress with tracking down your issues? Did you maybe try to use krita from .appimage?

Axis4s commented 1 year ago

Is there any progress with tracking down your issues? Did you maybe try to use krita from .appimage?

sorry for the late response, bug still persists on the appimage version

Axis4s commented 1 year ago

image Screenshot_2023-05-05_16-59-55 Screenshot_2023-05-05_17-00-36

btw here if you still didn't understand, look at that stroke i did on the canvas, these are 2 separate screenshots and one with both overlayed on top of eachother For somereason this is happens everytime i open the shortcut composer pie, the pie settings persist there and its invisible

Axis4s commented 1 year ago

image image

here's a more clear view, i disabled my display compositor, so transparency effects are disabled there's the pie settings window

wojtryb commented 1 year ago

I'm afraid I won't be able to help you much here.

Both Pie and its settings are technically separate windows with usual frames disabled. They are marked in Qt5 as "Tools" which should result in OS treating them more like some kind of pop-up which can stay on top for some time, than a fully separate window. This seems to be respected correctly by Windows 10, 11 as well as Gnome and KDE Plasma.

While I'll be happy to have the plugin working on as many environments as possible, covering all of them is out of my scope. It's probably possible to fix your issue by trying out different settings for those windows, but I don't think I'll be able to take care of it in the nearest future.

Axis4s commented 1 year ago

I'm afraid I won't be able to help you much here.

Both Pie and its settings are technically separate windows with usual frames disabled. They are marked in Qt5 as "Tools" which should result in OS treating them more like some kind of pop-up which can stay on top for some time, than a fully separate window. This seems to be respected correctly by Windows 10, 11 as well as Gnome and KDE Plasma.

While I'll be happy to have the plugin working on as many environments as possible, covering all of them is out of my scope. It's probably possible to fix your issue by trying out different settings for those windows, but I don't think I'll be able to take care of it in the nearest future.

Im using EndeavourOS with XFCE, XFCE Is a lightweight desktop environment does XFCE have any kind of compatibility issue?

wojtryb commented 1 year ago

As the plugin is working on Gnome, Plasma and Windows, your desktop environment is most likely the problem.

I believe XFCE does not fully support Qt5 window flags, or it's a bug in handling tools. If you really like to further investigate the issue, you can go to ~/.local/share/krita/pykrita and remove the Qt.Tool flag from files:

This would make the OS treat both the pie and its settings as usual windows. It can result in things like krita losing focus when they appear, but could fix your problems (although this is a shot in a dark). That would confirm XFCE has a bug related to Qt.Tool flag.

Anyway, sorry but I can't really support niche environments like that :)