wokwi / easyeda2kicad

Convert EasyEDA designs to KiCad EDA
https://wokwi.com/tools/easyeda2kicad
Other
287 stars 39 forks source link

Error in conversion #1

Closed cmaxwellau closed 4 years ago

cmaxwellau commented 4 years ago

$ easyeda2kicad PCB1.0.json PCB1.0.kicad

Unsupported shape DIMENSION Unsupported shape DIMENSION Unsupported shape DIMENSION Unsupported shape DIMENSION Unsupported shape HOLE Unsupported shape HOLE Unsupported shape HOLE Unsupported shape HOLE /usr/local/lib/node_modules/easyeda2kicad/dist/spectra.js:26 .filter(function (it) { return it !== null; }) ^

TypeError: Cannot read property 'filter' of undefined at encodeObject (/usr/local/lib/node_modules/easyeda2kicad/dist/spectra.js:26:14) at encodeValue (/usr/local/lib/node_modules/easyeda2kicad/dist/spectra.js:20:12) at Array.map () at encodeObject (/usr/local/lib/node_modules/easyeda2kicad/dist/spectra.js:27:14) at encodeValue (/usr/local/lib/node_modules/easyeda2kicad/dist/spectra.js:20:12) at Array.map () at encodeObject (/usr/local/lib/node_modules/easyeda2kicad/dist/spectra.js:27:14) at encodeValue (/usr/local/lib/node_modules/easyeda2kicad/dist/spectra.js:20:12) at Array.map () at encodeObject (/usr/local/lib/node_modules/easyeda2kicad/dist/spectra.js:27:14)

Underlying object:

[
  'fp_line',
  [ 'start', -7.549997600000012, 3.599992800000038 ],
  [ 'end', 1.2500101999999913, 3.599992800000038 ],
  [ 'width', 0.049987199999999996 ],
  [ 'layer', undefined ],
  null,
  null
]

Original EasyEDA project:

[(https://easyeda.com/sundbyk/gotek)]

urish commented 4 years ago

Seems like the issue caused by the fact we don't have mapping for layer number 15 ("Mechanical"). I will look into it.

urish commented 4 years ago

I have published a new release (1.1.1) with this fix. I tested it with your board, it seems to convert it successfully. I'd love to have your feedback about the result of the conversion.

By the way, how did you find out about this project? And how do you find converting easyeda to kicad useful? I'm planning to write a blog post about this tool, and your input can be really useful!

cmaxwellau commented 4 years ago

Thanks uri,

Will test it out again soon. I found this with a Google search for easyeda, kicad and conversion. As a node developer by day who is getting back into some retro computing projects I thought it was worth checking out :)

On Wed, Oct 30, 2019, 04:24 Uri Shaked notifications@github.com wrote:

I have published a new release (1.1.1) with this fix. I tested it with your board, it seems to convert it successfully. I'd love to have your feedback about the result of the conversion.

By the way, how did you find out about this project? And how do you find converting easyeda to kicad useful? I'm planning to write a blog post about this tool, and your input can be really useful!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/urish/easyeda2kicad/issues/1?email_source=notifications&email_token=AAEVAIPMXB62CAJVI3DFFODQRBWUVA5CNFSM4JFUJHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECRMFUY#issuecomment-547537619, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEVAII5X6VFL6JZKDBVQJ3QRBWUVANCNFSM4JFUJHAA .