Components package rotation issues

wokwi / easyeda2kicad

Convert EasyEDA designs to KiCad EDA

https://wokwi.com/tools/easyeda2kicad

Other

287 stars 39 forks source link

Components package rotation issues #11

Closed mtiutiu closed 4 years ago

mtiutiu commented 4 years ago

Description: It seems that this QFN 48 package is rotated 180 degree after conversion. This happens with other SMD components on the board also like some decoupling capacitors around the QFN 48 IC.

Expected result: Should have the right rotation for component packages after conversion.

Please see attached screenshots.

After conversion: package_rotation

Original: original_package

EasyEDA project: Touch_Switch_2ch.zip

I tested it using latest master code as it was now at this time of writing.

mtiutiu commented 4 years ago

Other components facing the same issue (180 degree rotation). As seen in the pictures those SMD packages are basically flipped.

After conversion:

rotated_comp_around_ic

Original:

original_smd_around_ic

urish commented 4 years ago

So far, it seems to me to rotated components get flipped on the Y-axis, though I haven't managed to figure out a way to determine which ones get flipped

mtiutiu commented 4 years ago

@urish Hey, any progress on this? I would really like to "port" some of my projects from EasyEDA to KiCAD. Thanks.

urish commented 4 years ago

Hi @mtiutiu , unfortauntely, I haven't had a chance to work in it since. I'll give it another shot this weekend and keep you posted!

Other than this and the shifting, are there any other issues that prevent the EasyEDA → KiCad conversion?

mtiutiu commented 4 years ago

Hi @mtiutiu , unfortauntely, I haven't had a chance to work in it since. I'll give it another shot this weekend and keep you posted!

Other than this and the shifting, are there any other issues that prevent the EasyEDA → KiCad conversion?

Haven't seen anything else so far.

mtiutiu commented 4 years ago

Hi @urish any progress with the current issues? Thanks.

urish commented 4 years ago

Hi @mtiutiu , thanks for the ping - I haven't had a chance to look into it since that weekend.

If you do have some time to recreate a minimal example (with just one or two components) that reproduces the issue that could really be helpful to expedite the process

mtiutiu commented 4 years ago

Hi @urish

Sure. Here's another one more simpler:

Original:

Conversion: Screenshot from 2020-01-16 15-58-05

PCB source and result of conversion:

sample_project.zip

I tested it using latest master code as it was now at this time of writing.

Let me know if you need additional details. Thanks.

urish commented 4 years ago

Thanks @mtiutiu !

urish commented 4 years ago

Alright, I think I found the issue after some extensive hunt. Can you please try again and report?

mtiutiu commented 4 years ago

Oh man - you're awesome! This fixed it. I want to try with some other boards that I have and report back. Thanks a lot, I really appreciate it.

mtiutiu commented 4 years ago

Yep, it seems fine now. I think this ticket can be closed now. Thanks a lot.

urish commented 4 years ago

Lovely, I will cut a new release

urish commented 4 years ago

Released 1.3.2 with this fix