Closed mtiutiu closed 4 years ago
Can you please check again with latest version from master?
@urish
Hi, the conversion process is crashing with an exception now:
/home/mtiutiu/Tmp/easyeda2kicad/dist/board.js:319
var isSmd = shapes.some(function (shape) { return shape[0] === 'pad' && shape[2] === 'smd'; });
^
TypeError: Cannot read property '0' of null
at /home/mtiutiu/Tmp/easyeda2kicad/dist/board.js:319:60
at Array.some (<anonymous>)
at convertLib (/home/mtiutiu/Tmp/easyeda2kicad/dist/board.js:319:24)
at convertShape (/home/mtiutiu/Tmp/easyeda2kicad/dist/board.js:391:21)
at /home/mtiutiu/Tmp/easyeda2kicad/dist/board.js:403:148
at Array.map (<anonymous>)
at Object.convertBoard (/home/mtiutiu/Tmp/easyeda2kicad/dist/board.js:403:118)
at Object.<anonymous> (/home/mtiutiu/Tmp/easyeda2kicad/dist/main.js:17:84)
Should be fixed by #20, can you give it another go?
Yep. Works now as expected. See attached picture.
Awesome! released as 1.4.0
Description: Seems that some symbols present on the PCB silkscreen (top and/or bottom) are not converted completely leading to an incomplete drawing. See the "high voltage symbols" in the attached pictures.
Expected result: Any silkscreen symbols should be fully translated.
Original:![Screenshot from 2020-01-29 15-34-47](https://user-images.githubusercontent.com/2891463/73428804-c6c62b80-4342-11ea-9955-de2c128cc59d.png)
Conversion result:![Screenshot from 2020-01-30 09-30-27](https://user-images.githubusercontent.com/2891463/73429027-4d7b0880-4343-11ea-9923-8a9c875963dd.png)
Project files: project.zip
KiCAD version (latest stable): 5.1.5 easyeda2kicad version: 1.3.4
If any other details are needed please let me know. Thanks.