search

wokwi / rp2040js

A Raspberry Pi Pico Emulator in JavaScript
MIT License
403 stars 46 forks source link

feat(RP2040): implemented RESET_BASE peripherals #34

Closed Turro75 closed 3 years ago

Turro75 commented 3 years ago

It does nothing special, it just remove some annoying unimplemented peripherals output messages.

Gym to practice on implementing peripherals

urish commented 3 years ago

It does nothing special, it just remove some annoying unimplemented peripherals output messages.

Clearing the noise is very important!

urish commented 3 years ago

Thanks!

Can you please move the hardware divider code into a different pull request?

One way to do it is to create a new branch from master, e.g. hardware-divider:

git fetch origin
git checkout -b hardware-divider origin/master
git cherry-pick 52d0c3d559aa116af2d2d3260b297ebbbe757844

then create a pull request from that branch (the last command copies a specific commit into the new branch)

Also, can you please check the new divider implementation against hello_divider and pico_divider_test (@kilograham mentioned that the version in develop branch is the most recent one)?