feat(logging): Added basic logging functionality

wokwi / rp2040js

A Raspberry Pi Pico Emulator in JavaScript

MIT License

400 stars 44 forks source link

feat(logging): Added basic logging functionality #45

Closed proteusnet closed 3 years ago

proteusnet commented 3 years ago

Also added utility methods and moved the name parameter to the invididual calls, ready for re-review. Triple checked I ran prettier this time too, let me know if its not what you expect.

urish commented 3 years ago

Meanwhile, I also found out why prettier wasn't running automatically for every commit: 7f47c56998c7f7af4457ae4461d5e143514a9a35.

So for now, you'll still need to run prettier (and eslint) manually for the files in this pull-request, unless you rebase your branch on top of master and npm install. If want to rebase and need any help with that, I'm here to assist.

proteusnet commented 3 years ago

Done, ready for review, i dont have much more time to spend on this, so hopefully its useful as it is.

urish commented 3 years ago

Very useful, thank you for working on it!

I merged and added a bunch of small fixes: f7664eced30f99bf87a77bcd9038cdaadbf69fc7, and I'll mention this in the next live stream