wokwi / rp2040js

A Raspberry Pi Pico Emulator in JavaScript
MIT License
389 stars 40 forks source link

fix(rp2040): fix subs registers wrong overflow handling #47

Closed Turro75 closed 3 years ago

Turro75 commented 3 years ago

close #46

urish commented 3 years ago

Also, can you move the STR fix into a different pull request (different branch), together with the test case from #43?

I think a bunch of other instructions have the same issue as well: STRH, STRB, LDR, LDRB, LDRH, LDRS, LDRSB

We can skip creating tests for each one of them, but since we already have the test case for STR, let's at least include it

edit: pardon, I see you already included the test case for STR. I guess I'm too tired at this hour :)

Turro75 commented 3 years ago

I'm gonna reworking it

urish commented 3 years ago

Thank you!