Invalid "type" in esm/package.json

wokwi / rp2040js

A Raspberry Pi Pico Emulator in JavaScript

MIT License

384 stars 40 forks source link

Invalid "type" in esm/package.json #89

Closed a2 closed 2 years ago

a2 commented 2 years ago

I'm seeing the below error from esbuild when I build a project that includes rp2040js. If I change the value there (locally) to "module" then everything still works (from my testing).

▲ [WARNING] "esm" is not a valid value for the "type" field

    node_modules/rp2040js/dist/esm/package.json:1:8:
      1 │ {"type":"esm"}
        ╵         ~~~~~

  The "type" field must be set to either "commonjs" or "module".

urish commented 2 years ago

Thanks for reporting! TBH I don't really remember why we used "esm", but let's fix this

urish commented 2 years ago

Fix released as 0.14.7