search

wokwi / wokwi-elements

Web Components for Electronics and IoT Parts
https://elements.wokwi.com/
MIT License
185 stars 50 forks source link

Tiny fix to the Arduino Uno element SVG #112

Closed arduino12 closed 2 years ago

arduino12 commented 2 years ago

This is a very small issue but as a hardware guy I can't ignore it (so many chips got fried due to this!)

The bent at the top side of the atmega328 chip is missing! image

It should look like this SVG.

On the attiny85 it is right (Also with the pin1 dot mark!): image

It also seen at the uno on the wokwi page

I would have created a PR, but I didnt find the uno.svg file.. so does the image is hard-codded in the arduino-uno-element.ts?

urish commented 2 years ago

Thanks for reporting! It's indeed hard-coded in that file

urish commented 2 years ago

Done!

arduino12 commented 2 years ago

@AriellaE Thanks!

  1. I think it will look better if you follow the origal darker color - fill="#252728"
  2. The pin1 dot mark doesn't look so good - so I think we better remove it.
  3. Better copy the shape (half a circle path) from the attiny85 board :)

By changing the arduino-uno-element.ts extension from .ts to .svg and changing some numbers I made this: image By manually editing the text to:

  <g fill="#252728">
    <circle cx="33.269" cy="36.847" r="1" />
    <circle cx="59.939" cy="36.847" r="1" />
    <path d="M65 38.05a1.13 1.13 0 010-2.26v2.27z" />
  </g>

Made a PR :)