search

wokwi / wokwi-elements

Web Components for Electronics and IoT Parts
https://elements.wokwi.com/
MIT License
185 stars 49 forks source link

Adds a PC Fan and Robot Arm element #115

Closed yepher closed 2 years ago

yepher commented 2 years ago

This creates a PC Fan and Robot Arm element

yepher commented 2 years ago

I think we should hold off on this PR. I am thinking this would be better if each joint was controllable. I was playing with this last night and now I have a lot better idea of how to use StoryBook. I think that will be more realistic for how this would work in the real world.

robot_4_angles

urish commented 2 years ago

Thanks Chris!

I love it. So let's break it into two PRs: one for the fan and the other one for the robotic arm?

Also, regarding the robotic arm, this brings an interesting question: what should the bounding box be?

yepher commented 2 years ago

I will break it up. And was wondering the same thing about the bounding box. Previously I took the full space the arm can move. Not sure if it can be dynamic or possibly draw outside it's box...

urish commented 2 years ago

Thanks!

Dynamic - yes. Not sure if it'll work in Wokwi out of the box though - we can try and see if it breaks anything.

Draw out of the box - not in SVG. You can resize the SVG, though, and move it relative to the container element, so Wokwi still thinks the box (the containing elements) is smaller, and draw the marching ants around it. I'm not sure if this will lead to good UX, however?