search

wokwi / wokwi-elements

Web Components for Electronics and IoT Parts
https://elements.wokwi.com/
MIT License
185 stars 49 forks source link

Nema Stepper Element #136

Closed bonnyr closed 1 year ago

bonnyr commented 2 years ago

Added a new element to represent Steppers based on popular Nema sizes

Example images:

image image
bonnyr commented 2 years ago

@AriellaE any feedback on this PR?

AriellaE commented 2 years ago

Hi @bonnyr , thank you for creating all these steppers sizes. Can you please implement the size change feature in our original stepper motor? Please let me know if you need any guidance.

bonnyr commented 2 years ago

@AriellaE did you mean you want me to modify the original?

AriellaE commented 2 years ago

@bonnyr yes please

bonnyr commented 1 year ago

@AriellaE - modified stepper element as requested (removed the added nema-* variant)

bonnyr commented 1 year ago

It looks very good, thank you! great :)

Few more comments:

  1. Text size of value must always be larger than units (the proportions should be around 14:24) , and now that there are size option to the stepper itself, the texts should grow and shrink as the stepper.

Modified the units property text size to be 2/3 of the value . The text size itself is already a function of the selected instance size (see textSize property value in the NEMASpec class)

  1. In storybook please cancel the rotation animation(although it very pretty) . You can create a new story that contains the animation, but all the other stories (including default story) should be static with the ability of controlling the angle.

Removed animation altogether. For some reason it does not want to work when I apply to Template type stories (all other stories using animation make direct use of storiesOf and friends)

Hope this is it...

bonnyr commented 1 year ago

@AriellaE - any update?

AriellaE commented 1 year ago

Hi @bonnyr
I merged the changes released new version and uploaded it to wokwi.com. Thanks again for contributing to Wokwi! Shana tova 🍯🍎