ESP32 Arduino - NVS stopped working - Githubissues

wokwi / wokwi-features

Wokwi Feature requests & Bug Reports

https://wokwi.com

73 stars 17 forks source link

ESP32 Arduino - NVS stopped working #811

Closed P-R-O-C-H-Y closed 5 months ago

P-R-O-C-H-Y commented 5 months ago

Describe the bug In recent Wokwi version the NVS stopped working for ESP32, ESP32S2, ESP32S3 and ESP32C3.

Link to failed CI run: https://github.com/espressif/arduino-esp32/actions/runs/9641334301/job/26586787348

To Reproduce Tests binaries can be downloaded from CI run in artifacts: https://github.com/espressif/arduino-esp32/actions/runs/9641314348

Expected behavior Test should pass as it works on real HW and worked before on Wokwi also.

Environment (please complete the following information): Github CI: platform linux -- Python 3.12.4, pytest-8.2.2, pluggy-1.5.0

urish commented 5 months ago

I believe this was the same issue as #810 and should now be fixed, can you please try again?

P-R-O-C-H-Y commented 5 months ago

Still not working for me.

2024-06-24 14:04:39 Wokwi CLI v0.10.1 (62244647f25e)
2024-06-24 14:04:39 Connected to Wokwi Simulation API 1.0.0-20240624-ga03d9ec4
2024-06-24 14:04:46 Starting simulation...
2024-06-24 14:04:46 ESP-ROM:esp32c3-api1-20210207
2024-06-24 14:04:46 Build:Feb  7 2021
2024-06-24 14:04:46 
2024-06-24 14:04:46 rst:0x1 (POWERON),boot:0xc (SPI_FAST_FLASH_BOOT)
2024-06-24 14:04:46 SPIWP:0xee
2024-06-24 14:04:46 
2024-06-24 14:04:46 mode:DIO, clock div:1
2024-06-24 14:04:46 load:0x3fcd6100,len:0x420
2024-06-24 14:04:46 load:0x403ce000,len:0x90c
2024-06-24 14:04:46 
2024-06-24 14:04:46 load:0x403d0000,len:0x2370
2024-06-24 14:04:46 entry 0x403ce000
2024-06-24 14:04:46 Current counter value: 0
2024-06-24 14:04:48 ESP-ROM:esp32c3-api1-20210207
2024-06-24 14:04:48 
2024-06-24 14:04:48 Build:Feb  7 2021
2024-06-24 14:04:48 rst:0x1 (POWERON),boot:0xc (SPI_FAST_FLASH_BOOT)
2024-06-24 14:04:48 invalid header: 0xffffffff
2024-06-24 14:04:48 invalid header: 0xffffffff
2024-06-24 14:04:48 
2024-06-24 14:04:48 invalid header: 0xffffffff
2024-06-24 14:04:48 invalid header: 0xffffffff
2024-06-24 14:04:48 invalid header: 0xffffffff
2024-06-24 14:04:48 invalid header: 0xffffffff
2024-06-24 14:04:48 invalid header: 0xffffffff
2024-06-24 14:04:48

urish commented 5 months ago

Yeah, the issue reproduces for the on the ESP32-C3. Looking into it.

urish commented 5 months ago

Issue found, working on a fix.

urish commented 5 months ago

Pushed a fix - can you please test once more?

P-R-O-C-H-Y commented 5 months ago

Pushed a fix - can you please test once more?

ESP32S2 still not working. But S3 and C3 fixed.

https://github.com/espressif/arduino-esp32/actions/runs/9645751282/job/26600656491#step:11:188

urish commented 5 months ago

Thanks! Issues found, working on a fix.

urish commented 5 months ago

Pushed a fix.

Also, in order to avoid future NVS regressions, I added the ESP-IDF nvs driver tests to our CI:

Before the fix: https://github.com/wokwi/esp32-test-binaries/actions/runs/9652601127/job/26623081200 🔴 (S2/C6/H2/P4 failing)
Now: https://github.com/wokwi/esp32-test-binaries/actions/runs/9652694870/job/26623386390 🟢

P-R-O-C-H-Y commented 5 months ago

@urish Thank you for a quick fix! All tests passing now. Great job.