search

woldner / VisualLinter

Visual Studio Linter using ESLint.
MIT License
25 stars 3 forks source link

Incompatibility with Extension Vue.js Pack 2017 #41

Closed zcharleshebert closed 6 years ago

zcharleshebert commented 6 years ago

Installed product versions

Steps to recreate

  1. Have a already working Vuejs project with linting (via VisualLinter) works
  2. Install latest version of Vue.js Pack 2017 extension
  3. Open any .vue files
  4. Eslint not working for .vue files, but still work for .js files

Current behavior

VisualLinter doesn't lint .vue files anymore

Expected behavior

VisualLinter should lint supported files even with other extensions installed (imo)

Notes ;p

It seems that Vue.js Pack 2017 adds intellisense/goodies to the .vue file in a way that changes the ContentType of Vue Files that you open.

I could make it work by adding [ContentType("projection")] to the TaggerProvidder class -> Here

...but I was wondering if that was the right way of doing this ?

Please let me know ASAP, since it would be game changing for our team...

So I'll make the PR for you. :)

Cheers, C

woldner commented 6 years ago

Hey @zcharleshebert !

Its absolutely fine to add the [ContentType("projection")] in the TaggerProvider class. Send me a pull request and I'll make it happen!

For reference: https://github.com/MicrosoftDocs/visualstudio-docs/blob/master/docs/extensibility/inside-the-editor.md#projection

zcharleshebert commented 6 years ago

There you go @jwldnr, I created the PR!

woldner commented 6 years ago

closed in #42

Thanks for the help @zcharleshebert !

woldner commented 6 years ago

Added in v1.1.60.

zcharleshebert commented 6 years ago

My pleasure @jwldnr !