Publish new version with fix for Newtonsoft.Json not found

[madskristensen]

You don't actually have to include newtonsoft.json.dll in the .vsix. It is considered a bad practice to do so. You just have to use a lower version to make the binding redirects work in VS2017. Downgrade JSON.NET to version 8 and don't include it in the VSIX and it should work fine.

But regardless of downgrading or including the latest version, can you please update the extension on the Marketplace with the fix?

[woldner]

Hey @madskristensen thanks for the feedback!

I've created a pull request with requested changes (https://github.com/jwldnr/VisualLinter/pull/48):

• no longer include Newtonsoft.Json.dll in the .vsix
• downgrade Newtonsoft.Json.dll to v9.0.1
• add binding redirect from version range 0.0.0.0-11.0.0.0 to 9.0.0.0

was it something like this you had in mind?

[madskristensen]

Don't do binding redirects. Visual STudio ships with those for JSON.NET. It's better to downgrade to version 8 to make sure it works with un-updated versions of VS2017. VS will automatically update it using binding redirects to version 9

[woldner]

Alright @madskristensen, fair point. Any specific version 8 or will any do?

[madskristensen]

8.0.3 will do. Generally speaking, when using JSON.NET in a VS extension always use the lowest possible version you can. So if you can use version 6 in your extension then do that instead.

[woldner]

Thanks @madskristensen, I must admit it has given me some headaches. I'll downgrade to v8.0.3 and release it to the marketplace, but I'll be sure to research earlier versions as well.

[madskristensen]

awesome

[woldner]

fixed in #48 a new version will soon be available on the Marketplace. Thanks @madskristensen!