kloczek
commented
3 years ago Open kloczek opened 3 years ago
kloczek
commented
3 years ago kloczek
commented
2 years ago Looks like test suite is using nose which should not be used with python 3.x https://nose.readthedocs.io/en/latest/
So that issue needs to be resolved first :)
+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-parameterized-0.8.1-2.1.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-parameterized-0.8.1-2.1.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/pytest -ra parameterized/test.py --deselect parameterized/test.py::TestUnicodeDocstring::test_with_docstring_0_value1 --deselect parameterized/test.py::TestUnicodeDocstring::test_with_docstring_1_v_l_
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.12, pytest-6.2.5, py-1.11.0, pluggy-1.0.0
rootdir: /home/tkloczko/rpmbuild/BUILD/parameterized-0.8.1
collected 0 items / 1 error
================================================================================== ERRORS ==================================================================================
__________________________________________________________________ ERROR collecting parameterized/test.py __________________________________________________________________
ImportError while importing test module '/home/tkloczko/rpmbuild/BUILD/parameterized-0.8.1/parameterized/test.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.8/importlib/__init__.py:127: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
parameterized/test.py:6: in <module>
from nose.tools import assert_equal, assert_raises
E ModuleNotFoundError: No module named 'nose'
========================================================================= short test summary info ==========================================================================
ERROR parameterized/test.py
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
============================================================================= 1 error in 0.17s =============================================================================
paulgevers
commented
2 years ago paul@mulciber ~/packages/bugs/python-parameterized $ python3.9 -m pytest -v --pyargs parameterized.testThe test has 2 items, but results in the test being run 3 times, where the third time fails because it wasn't expected AFAICT.
parameterized/test.py::TestUnicodeDocstring::test_with_docstring_0_value1 PASSED [ 98%]
parameterized/test.py::TestUnicodeDocstring::test_with_docstring_1_v_l_ PASSED [100%]
parameterized/test.py::TestUnicodeDocstring::test_with_docstring_1_v_l_ ERROR [100%]paul@mulciber ~/packages/bugs/python-parameterized $ python3.9 -m pytest -v --pyargs parameterized.test
On execution python -m foo python automatically adds upfront to sys.path curent direstory.
pytest shound not be used that way and this is why is provided /usr/nin/pytest script.
paulgevers
commented
2 years ago /usr/bin/pytest-3 fails in the same way:
paul@mulciber ~/packages/bugs/python-parameterized.team $ pytest-3 parameterized/test.py
==================================== test session starts ====================================
platform linux -- Python 3.9.10, pytest-6.2.5, py-1.10.0, pluggy-0.13.0
rootdir: /home/paul/packages/bugs/python-parameterized.team
collected 59 items
parameterized/test.py ...........xx......x......xx....................x.s..xxxx..E [100%]
========================================== ERRORS ===========================================
___________ ERROR at teardown of TestUnicodeDocstring.test_with_docstring_1_v_l_ ____________
def tearDownModule():
missing = sorted(list(missing_tests))
> assert_equal(missing, [])
parameterized/test.py:371:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/usr/lib/python3.9/unittest/case.py:837: in assertEqual
assertion_func(first, second, msg=msg)
/usr/lib/python3.9/unittest/case.py:1043: in assertListEqual
self.assertSequenceEqual(list1, list2, msg, seq_type=list)
/usr/lib/python3.9/unittest/case.py:1025: in assertSequenceEqual
self.fail(msg)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <nose.tools.trivial.Dummy testMethod=nop>
msg = 'Lists differ: ["test_instance_method(\'foo0\', bar=None)",[461 chars]o\')"] != []\n\nFirst list contains 12 additiona...1, \'umask\', \'getpid\')",\n- "test_patch_no_expand(42, 51, \'umask\')",\n- "test_wrapped_iterable_input(\'foo\')"]'
def fail(self, msg=None):
"""Fail immediately, with the given message."""
> raise self.failureException(msg)
E AssertionError: Lists differ: ["test_instance_method('foo0', bar=None)",[461 chars]o')"] != []
E
E First list contains 12 additional elements.
E First extra element 0:
E "test_instance_method('foo0', bar=None)"
E
E + []
E - ["test_instance_method('foo0', bar=None)",
E - "test_instance_method('foo1', bar=None)",
E - "test_instance_method('foo2', bar=42)",
E - 'test_instance_method(42, bar=None)',
E - "test_mock_patch_standalone_function(42, 'umask')",
E - "test_naked_function('foo0', bar=None)",
E - "test_naked_function('foo1', bar=None)",
E - "test_naked_function('foo2', bar=42)",
E - 'test_naked_function(42, bar=None)',
E - "test_patch_class_no_expand(42, 51, 'umask', 'getpid')",
E - "test_patch_no_expand(42, 51, 'umask')",
E - "test_wrapped_iterable_input('foo')"]
/usr/lib/python3.9/unittest/case.py:676: AssertionError
pgajdos
commented
2 years ago Also, please consider to use unittest.mock instead of mock, as a fallback at least.