search

wolever / pprintpp

pprint++: a drop-in replacement for pprint that's actually pretty
Other
408 stars 21 forks source link

Apply pep8 and pyflakes #11

Closed hugovk closed 10 years ago

hugovk commented 10 years ago

pep8 is for style. pyflakes finds programming errors. Also report after successful Travis jobs.

wolever commented 10 years ago

Sorry, but I don't want my Travis build failing because of stylistic errors. Additionally, I'm not a huge fan of all of the pep8/pyflakes changes. If you want to have the checks, though, feel free to add them to tox.ini file: http://www.dominicrodger.com/tox-and-travis.html and disable the whitespace-related checks.

hugovk commented 10 years ago

OK, no problem!

These things won't cause any Travis failures. They're just reported at the end of an already successful build.

pep8 is just style, but pyflakes is worth keeping an eye on as it can show logical errors like referring to undefined variables.

Anyway, I've never used tox before, I'll look into it.