search

wolever / pprintpp

pprint++: a drop-in replacement for pprint that's actually pretty
Other
408 stars 21 forks source link

Python 3 compatibility #8

Closed ulope closed 10 years ago

ulope commented 10 years ago

It would be nice if pprintpp were be Python 3 compatible

wolever commented 10 years ago

It would! Would you be interested in taking lead on the porting effort?

ulope commented 10 years ago

I'll give it a shot. It'd probably be a good idea to add some tests in the process to ensure there are no bugs introduced by the porting.

hugovk commented 10 years ago

@ulope See #9 to use Travis CI to ensure compatibility on Python 2.6, 2.7, 3.2, 3.3 (3.4 soon) and PyPy.

wolever commented 10 years ago

Woo! Thanks, @hugovk! @ulope: let me know if there's anything I can help with.

wolever commented 10 years ago

Okay, I've tweaked things a bit so tests are now in a kind of real tests.py file and can be run with tox too!

hugovk commented 10 years ago

:+1:

It's already finding Python 3 incompatibilities: https://travis-ci.org/wolever/pprintpp/builds/23518636

wolever commented 10 years ago

Okay… I've started on the port. Will update here when something's working.

wolever commented 10 years ago

Okay! And with 67da884, we should be working with Py3.

wolever commented 10 years ago

I've removed py26 and py32 support because I don't see a compelling reason to keep it, given that they will require much larger changes.

ulope commented 10 years ago

Oh wow you worked fast. Sorry I didn't do anything. Was away a few days.

hugovk commented 10 years ago

@ulope: No problem! Wouldn't have happened (yet...) if you hadn't suggested it!