rampageX commented 4 years ago

…e letter

When resolve a domain that include uppercase letter, ts-dns do not match the right way with gfwlist, let's fix it.

codecov-commenter commented 4 years ago

Codecov Report

Merging #29 into master will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            master       #29    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           11        11            
  Lines          759       657   -102     
==========================================
- Hits           759       657   -102

Impacted Files	Coverage Δ
inbound/server.go	`100.00% <100.00%> (ø)`
cache/dns.go	`100.00% <0.00%> (ø)`
hosts/hosts.go	`100.00% <0.00%> (ø)`
cache/ramset.go	`100.00% <0.00%> (ø)`
cache/ttlmap.go	`100.00% <0.00%> (ø)`
cmd/conf/conf.go	`100.00% <0.00%> (ø)`
inbound/tools.go	`100.00% <0.00%> (ø)`
core/common/dns.go	`100.00% <0.00%> (ø)`
matcher/adblock.go	`100.00% <0.00%> (ø)`
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48a90c7...3e355ac. Read the comment docs.

wolf-joe commented 4 years ago

开启dirty first后，如果解析结果出现非CN IP，就直接用dirty组dns解析，而不考虑gfwlist，是这样吗？

wolf-joe commented 4 years ago

这样的话，直接在gfwlist里写个通配符*，也能实现同样的效果吧……如果我没记错😂

rampageX commented 4 years ago

开启dirty first后，如果解析结果出现非CN IP，就直接用dirty组dns解析，而不考虑gfwlist，是这样吗？

是，可选嘛。我也还在测试，不知道怎么就提交了...

之前那个域名大写的问题可以考虑合并下。。。

wolf-joe commented 4 years ago

这个pull request已经有两个commit了，不能只合并部分commit。我刚推了三个commit来fix来解决hosts/matcher/cache的大小写问题，不过返回缓存结果时，结果里域名的大小写应该和请求里域名的大小写一致，这个还没搞定。

wolf-joe / ts-dns

fix error resolve because wrong grouping when domain include uppercas… #29

Codecov Report