wolf-plugins / wolf-shaper

Waveshaper plugin with a spline-based graph editor (LV2, VST, and CLAP)
https://wolf-plugins.github.io/wolf-shaper/
GNU General Public License v3.0
221 stars 20 forks source link

Packaging, contrib files and location #117

Closed dvzrv closed 5 years ago

dvzrv commented 6 years ago

I would like to move the latest stable version of this nice plugin to Arch Linux' [community] repository. I see you already did some work on trying to ease the work for package maintainers and the like in #42. However, I have some questions and notes on it:

trebmuh commented 6 years ago

the XDG desktop file and icon should not be located in pkg/debian/, as those files apply to all distros. a contrib directory would probably be more reasonable.

agreed

the Debian packaging should be dealt with downstream as well (same reasons as with Arch Linux packaging), or are you building this package and publishing it somewhere?

I would think that this debian packaging is great to have here as long as it's not in the Debian repo since it eases installing Wolf-Shaper properly (think "package management tools") on Debian and derivated systems for now.

as this git repository contains some submodules, it would be great, if you could release a source code version with the submodules already checked out (as reference, have a look at how this was achieved for supercollider's sc3-plugins).

agreed

pdesaulniers commented 6 years ago

the XDG desktop file and icon...

I would just get rid of those, unless @trebmuh is against it :)

the Debian packaging should be dealt with downstream as well (same reasons as with Arch Linux packaging), or are you building this package and publishing it somewhere?

I'm using this package for the Ubuntu PPA. I don't know what would be the process to get the package into the main Debian repo, so I'm leaving it here for now.

I'll look into the other points.

trebmuh commented 6 years ago

the XDG desktop file and icon... I would just get rid of those, unless @trebmuh is against it :)

I'll still providing those for LZK but here is your repo, so do as you want.

pdesaulniers commented 6 years ago

@dvzrv Should be good now.

dvzrv commented 6 years ago

@pdesaulniers so far so great! is your pgp public key not on any keyserver though?

dvzrv commented 6 years ago

Apart from that: now in [community].

pdesaulniers commented 6 years ago

Thanks!

Yes, I forgot to send the key. Should be OK now, I think.

pdesaulniers commented 5 years ago

I suppose I can close this :)