search

wolf-plugins / wolf-shaper

Waveshaper plugin with a spline-based graph editor (LV2, VST, and CLAP)
https://wolf-plugins.github.io/wolf-shaper/
GNU General Public License v3.0
219 stars 20 forks source link

Plugin calls mutex.unlock() even if locking fails? #144

Closed pdesaulniers closed 3 years ago

pdesaulniers commented 3 years ago

This line of code:

https://github.com/wolf-plugins/wolf-shaper/blob/b5c8c457abbe2212ce20644895be4243a2ba5740/plugins/wolf-shaper/WolfShaperPlugin.cpp#L312

is followed by:

https://github.com/wolf-plugins/wolf-shaper/blob/b5c8c457abbe2212ce20644895be4243a2ba5740/plugins/wolf-shaper/WolfShaperPlugin.cpp#L403

I assume we should call unlock() only when tryLock() returns true.