search

wolf-tickets / conways-fight-for-survival

A nasty, short and brutish reimagining of Conway's Game of Life using Haskell.
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Bit of cleanup and organization #4

Closed McTano closed 5 years ago

McTano commented 5 years ago

Hey guys, did a little cleanup and fixed stuff stack build complained about. I think this should all be good, but was unsure about a couple points:

  1. not 100% I did the change to the cabal file right. EDITED: Okay, so I think I understand this now. We have a build target for Library, it lists the modules which will be required outside this module (directly or indirectly) under 'exposed-modules'. Then the build target which requires them (the executable) lists them again under 'other-modules'. This is fixed in the second commit on this branch. running 'stack ghci' now builds the modules correctly and loads them.
  2. I think we should gitignore everything in the .idea and .stack-work dirs. Do you concur?
  3. I'm assuming our src file can contain all of our code, possibly with sub-dirs for further organization. Main imports Lib, Lib imports anything else it needs. Anyone want to organize it differently?

summary of changes: -edited .gitignore to ignore whole .idea dir, .stack-work dir; removed .stack-work from git index -added Lib and Quadtree files -added Lib and Quadtree to 'other-modules' in cabal file -corrected 'GPLv3' to 'GPL-3' in cabal because stack-build complained.

wolf-tickets commented 5 years ago

Looks good. Merged.