search

wolf4ood / gremlin-rs

Gremlin Rust
Apache License 2.0
108 stars 30 forks source link

Fixed precision of g:Date values to milliseconds #130

Closed criminosis closed 3 years ago

criminosis commented 3 years ago

Closes #128

This PR is a breaking change upon dates that are currently serialized since they would be serialized as epoch seconds not epoch milliseconds, but the Tinkerpop standard for version 2 and version 3 expects milliseconds.

Given the library is still major version 0 such breaking changes are permitted per semver expectations, but wanted to call it out for your consideration when reviewing.

wolf4ood commented 3 years ago

Thanks :+1: :)