search

wolf4ood / gremlin-rs

Gremlin Rust
Apache License 2.0
106 stars 29 forks source link

Remove Websocket & Time crates #172

Closed criminosis closed 1 year ago

criminosis commented 1 year ago

I encountered a dependency issue due to the age of dependencies brought in through the websocket-rs crate and this crate's inclusion of time through chrono.

The websocket-rs crate is bringing a very old version of hyper and the time crate has a known issue but setting the feature flags as done in this PR avoids the issue.

I swapped the websocket-rs crate with using tungstenite which is one of the suggestions listed by websocket-rs and also because this crate already used async-tungstenite.

@wolf4ood if this is acceptable to you mind cutting a new release after its merged?

wolf4ood commented 1 year ago

@criminosis

just released a new version with this PR

https://crates.io/crates/gremlin-client

Thanks

criminosis commented 1 year ago

Wonderful. Thank you @wolf4ood!