wolf4ood / gremlin-rs

Gremlin Rust
Apache License 2.0
106 stars 30 forks source link

Feature/trim native tls and features #187

Open mlemesle opened 1 year ago

mlemesle commented 1 year ago

Supersedes #184

Closes #176 and #180

Hey there, I started again and successfully trimed native-tls from the dependencies and moved tokio-native-tls to rustls-webpki. All tests pass for async-std and tokio-runtime !

There is still some work to do:

I also added a compilation failure if someone tries to use async-std-runtime and tokio-runtime at the same time.

What do you think of this ?

wolf4ood commented 1 year ago

@mlemesle

looks great, just one thing, why the tungstenite dep is via github? is it missing something there yet not released?

mlemesle commented 1 year ago

I forgot to mention. There was a lot of dep version issues. I had to fork 3 dependencies in order to fix this... PR are submitted, I'm waiting for a release to add it to Cargo.toml!

What about my previous points? Like moving async_gremlin to __async_gremlin?